On Tue, Feb 27, 2024 at 10:48:49AM -0500, Michael S. Tsirkin wrote:
> On Tue, Feb 27, 2024 at 06:21:46PM +0300, Dan Carpenter wrote:
> > The dev->vqs[] array has "dev->vq_num" elements. It's allocated in
> > vduse_dev_init_vqs(). Thus, this > comparison needs to be >= to avoid
> > reading one element beyond the end of the array.
> >
> > Fixes: 316ecd1346b0 ("vduse: Add file operation for mmap")
> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
>
> Oh wow and does this not come from userspace? If yes we
> need the speculation magic macro when using the index, do we not?
>
Yes, it does come from userspace.
To be honest, I'm not sure about speculation. The similar places in
this file protect against speculation so, probably? I'll resend the
patch.
regards,
dan carpenter
