On 2/21/24 11:14 PM, Dan Carpenter wrote:
> Smatch complains that %pa is for phys_addr_t types and "size" is a u64.
>
> drivers/cxl/core/hdm.c:521 cxl_dpa_alloc() error: '%pa' expects
> argument of type 'phys_addr_t*', argument 4 has type 'ullong*
>
> Looking at this, to me it seems more useful to print the sizes as
> decimal instead of hex. Let's do that.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Reviewed-by: Dave Jiang <dave.jiang@xxxxxxxxx>
> ---
> drivers/cxl/core/hdm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cxl/core/hdm.c b/drivers/cxl/core/hdm.c
> index 7d97790b893d..0b1843631b26 100644
> --- a/drivers/cxl/core/hdm.c
> +++ b/drivers/cxl/core/hdm.c
> @@ -518,9 +518,9 @@ int cxl_dpa_alloc(struct cxl_endpoint_decoder *cxled, unsigned long long size)
> }
>
> if (size > avail) {
> - dev_dbg(dev, "%pa exceeds available %s capacity: %pa\n", &size,
> + dev_dbg(dev, "%llu exceeds available %s capacity: %llu\n", size,
> cxled->mode == CXL_DECODER_RAM ? "ram" : "pmem",
> - &avail);
> + (u64)avail);
> rc = -ENOSPC;
> goto out;
> }
