On Thu, Feb 22, 2024 at 12:08:28AM +0000, Colin King (gmail) wrote: > On 22/02/2024 00:04, Kent Overstreet wrote: > > On Wed, Feb 21, 2024 at 11:52:03AM +0000, Colin Ian King wrote: > > > Variable ret is being assigned a value that is never read, it is > > > being re-assigned a couple of statements later on. The assignment > > > is redundant and can be removed. > > > > > > Cleans up clang scan build warning: > > > fs/bcachefs/super-io.c:806:2: warning: Value stored to 'ret' is > > > never read [deadcode.DeadStores] > > > > > > Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx> > > > > I'll take this, but - entirely too much of the traffic on this list is > > getting taken up by static analyzer bullshit, we need to cut down on > > this > > I'll back off then. Maybe just wrap up fixes for all the warnings every now and then? It is worth keeping up on static analyzer warnings, it's just the mailing list noise I want to cut down on, as well as making better use of my own time. I'd be happy to take a patch like that now and then, or - maybe we could get a dashboard going, like I was just running by Dan in the other thread? If we could get a dirt simple stupid dashboard that had both the clangc analyzer warnings, and the smatch warnings - I think that would make a lot of people happy.
