Re: [PATCH] mm: use ERR_CAST() as a cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 21, 2024 at 06:23:06AM +0000, Matthew Wilcox wrote:
> On Wed, Feb 21, 2024 at 09:22:13AM +0300, Dan Carpenter wrote:
> > The ->page is the first and only member of the folio struct so this code
> > works fine.  However, if we use ERR_CAST() then it's clearer that
> > this is an error pointer.
> 
> NAK.  &folio->page is an indicator that this code is in need of cleanup.
> I use it in my scripts.

Ah.  Fair enough.

regards,
dan carpenter




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux