On 2024-02-06 16:40, Markus Elfring wrote: > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > Date: Tue, 6 Feb 2024 16:30:15 +0100 > > A wrapper function is available since the commit 7945f929f1a77a1c8887a97ca07f87626858ff42 This line is needlessly long. Could you wrap it or shorten the SHA-1 ID? You don't need more than the first 12 characters of the SHA-1 ID. > ("drivers: provide devm_platform_ioremap_resource()"). > > * Thus reuse existing functionality instead of keeping duplicate source code. The same goes for this one. Please keep the width of the commit description within 75 characters. > * Delete a local variable which became unnecessary with this refactoring. > > > This issue was transformed by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> Apart from that the patch looks good. Thanks, Andreas