> -----Original Message----- > From: Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx> > > Commit 73cfbfa9caea ("ALSA: hda/cs35l56: Add driver for Cirrus Logic > CS35L56 amplifier") adds configs SND_HDA_SCODEC_CS35L56_{I2C,SPI}, > which selects the non-existing config CS_DSP. Note the renaming in > commit d7cfdf17cb9d ("firmware: cs_dsp: Rename KConfig symbol CS_DSP -> > FW_CS_DSP"), though. > > Select the intended config FW_CS_DSP. > > This broken select command probably was not noticed as the configs also > select SND_HDA_CS_DSP_CONTROLS and this then selects FW_CS_DSP. So, > the > select FW_CS_DSP could actually be dropped, but we will keep this > redundancy in place as the author originally also intended to have this > redundancy of selects in place. > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx> Thanks! Reviewed-by: Simon Trimmer <simont@xxxxxxxxxxxxxxxxxxxxx>