Re: [PATCH] pmdomain: mediatek: Use devm_platform_get_and_ioremap_resource() in init_scp()

[AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>]

Il 05/02/24 17:31, Geert Uytterhoeven ha scritto:
> Hi Markus,
>
> On Mon, Feb 5, 2024 at 3:23 PM Markus Elfring <Markus.Elfring@xxxxxx> wrote:
> > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> > Date: Mon, 5 Feb 2024 15:08:27 +0100
> >
> > A wrapper function is available since the commit 890cc39a879906b63912482dfc41944579df2dc6
> > ("drivers: provide devm_platform_get_and_ioremap_resource()").
> > Thus reuse existing functionality instead of keeping duplicate source code.
> >
> > This issue was detected by using the Coccinelle software.
> >
> > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/drivers/pmdomain/mediatek/mtk-scpsys.c
> > +++ b/drivers/pmdomain/mediatek/mtk-scpsys.c
> > @@ -441,8 +441,7 @@ static struct scp *init_scp(struct platform_device *pdev,
> >
> >          scp->dev = &pdev->dev;
> >
> > -       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > -       scp->base = devm_ioremap_resource(&pdev->dev, res);
> > +       scp->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>
> Given res is further unused, please use devm_platform_ioremap_resource()
> instead, and remove the local variable res.

Agreed: res will never be used.

Cheers,
Angelo