The variable trans_id is being modulo'd by channel->tre_count and the value is being re-assigned back to trans_id even though the variable is not used after this operation. The assignment is redundant. Remove the assignment and just replace it with the modulo operator. Cleans up clang scan build warning: warning: Although the value stored to 'trans_id' is used in the enclosing expression, the value is never actually read from 'trans_id' [deadcode.DeadStores] Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx> --- drivers/net/ipa/gsi_trans.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ipa/gsi_trans.c b/drivers/net/ipa/gsi_trans.c index ee6fb00b71eb..f5dafc2f53ab 100644 --- a/drivers/net/ipa/gsi_trans.c +++ b/drivers/net/ipa/gsi_trans.c @@ -247,7 +247,7 @@ struct gsi_trans *gsi_channel_trans_complete(struct gsi_channel *channel) return NULL; } - return &trans_info->trans[trans_id %= channel->tre_count]; + return &trans_info->trans[trans_id % channel->tre_count]; } /* Move a transaction from allocated to committed state */ -- 2.39.2
