Jens Axboe <axboe@xxxxxxxxx> writes: > On 1/12/24 7:25 AM, Gabriel Krisman Bertazi wrote: >> Markus Elfring <Markus.Elfring@xxxxxx> writes: >> >>> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> >>> Date: Wed, 10 Jan 2024 20:54:43 +0100 >>> >>> Another useful pointer was not reassigned to the data structure member >>> ?io_bl? by this function implementation. >>> Thus omit a redundant call of the function ?kfree? at the end. > > This is just nonsense... > > On top of that, this patch is pointless, and the 2nd patch is even worse > in that it just makes a mess of cleanup. And for what reasoning? > Absolutely none. Ah, The description is non-sense, but the change in this patch seemed correct to me, even if pointless, which is why I reviewed it. patch 2 is just garbage. > There's a reason why I filter emails from this particular author > straight to the trash, there's a long history of this kind of thing and > not understanding feedback. Clearly there is background with this author that I wasn't aware, and just based on his responses, I can see your point. So I apologize for giving him space to continue the spamming. My bad. -- Gabriel Krisman Bertazi
