>> The label “err” was used to jump to a kfree() call despite of >> the detail in the implementation of the function “io_ring_ctx_alloc” >> that it was determined already that a corresponding variable contained >> a null pointer because of a failed memory allocation. >> >> 1. Thus use more appropriate labels instead. >> >> 2. Reorder jump targets at the end. >> > > As I mentioned on v1, this doesn't do us any good, I dare to present other development views. > as kfree can handle NULL pointers just fine, Yes, this is the case. Would you dare to categorise such a special function calls as redundant? May it be skipped in more cases? > and changes like this becomes churn later when backporting or modifying the code. There are usual opportunities to consider for further collateral evolution. Regards, Markus
