> The label “err” was used to jump to a kfree() call despite of > the detail in the implementation of the function “io_ring_ctx_alloc” > that it was determined already that a corresponding variable contained > a null pointer because of a failed memory allocation. > > 1. Thus use more appropriate labels instead. > > 2. Reorder jump targets at the end. > > 3. Omit the statement “kfree(ctx->io_bl);”. Is this patch still in review queues? See also: https://lore.kernel.org/cocci/aa867594-e79d-6d08-a08e-8c9e952b4724@xxxxxx/ https://sympa.inria.fr/sympa/arc/cocci/2023-03/msg00114.html Regards, Markus