On Mon, Jan 08, 2024 at 10:21:51PM +0100, Christophe JAILLET wrote:
> Le 08/01/2024 à 22:15, Amit Dhingra a écrit :
> > On Mon, Jan 08, 2024 at 10:56:02AM +0300, Dan Carpenter wrote:
> > > Generally, patches to MAINTAINERS don't need Fixes tags.
> > >
> > > It doesn't matter if the patch is in mainline or not. If it's in a tree
> > > which is rebased then maintainers will fold the fix into the original
> > > commit and the Fixes tag will be lost. But that's fine.
> >
> > Makes sense. Thank you for the information and guidance.
> > >
> > > Also when you're using a Fixes tag, it should all go one one line.
> > > Don't line wrap it at 75 characters. Just go over the limit. That's
> > > the normal/correct way.
> > Also seems like checkpatch does not like the Fixes line without the
> > keyword Commit. So the fixes line below generates an Error.
> >
> > Fixes : 7564efb37346 ("MAINTAINERS: Add entry for TQ-Systems device
>
> Hi,
> try to remove the space after Fixes (i.e. Fixes: 7564efb37346)
>
> CJ
>
That worked. Great information. Thank you.
- Amit
