RE: [PATCH v2 2/2] cdx: Unlock on error path in rescan_store()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Subject: RE: [PATCH v2 2/2] cdx: Unlock on error path in rescan_store()
From: "Gangurde, Abhijit" <abhijit.gangurde@xxxxxxx>
Date: Thu, 4 Jan 2024 09:06:40 +0000
Accept-language: en-US
Cc: "Gupta, Nipun" <Nipun.Gupta@xxxxxxx>, "Agarwal, Nikhil" <nikhil.agarwal@xxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "kernel-janitors@xxxxxxxxxxxxxxx" <kernel-janitors@xxxxxxxxxxxxxxx>
In-reply-to: <a7994b47-6f78-4e2c-a30a-ee5995d428ec@moroto.mountain>
Msip_labels: MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_ActionId=43a8e5fb-76c2-42a4-b0a3-c1a559dc0a93;MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_ContentBits=0;MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_Enabled=true;MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_Method=Privileged;MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_Name=Non-Business-AIP 2.0;MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_SetDate=2024-01-04T09:04:25Z;MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;
References: <2e66efc4-a13a-4774-8c9d-763455fe4834@moroto.mountain> <a7994b47-6f78-4e2c-a30a-ee5995d428ec@moroto.mountain>

> We added locking to this function but these two error paths were
> accidentally overlooked.
> 
> Fixes: f0af81683466 ("cdx: Introduce lock to protect controller ops")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
Acked-by: Abhijit Gangurde <abhijit.gangurde@xxxxxxx>

Thanks,
Abhijit

References:
- [PATCH v2 1/2] cdx: call of_node_put() on error path
  - From: Dan Carpenter
- [PATCH v2 2/2] cdx: Unlock on error path in rescan_store()
  - From: Dan Carpenter

Prev by Date: RE: [PATCH v2 1/2] cdx: call of_node_put() on error path
Next by Date: Re: [1/3] drm: property: One function call less in drm_property_create() after error detection
Previous by thread: [PATCH v2 2/2] cdx: Unlock on error path in rescan_store()
Next by thread: RE: [PATCH v2 1/2] cdx: call of_node_put() on error path
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]