>> The kfree() function was called in up to two cases by >> the cros_ec_cmd_xfer_i2c() function during error handling >> even if the passed variable contained a null pointer. >> This issue was detected by using the Coccinelle software. >> >> * Adjust jump targets. >> >> * Delete two initialisations which became unnecessary >> with this refactoring. > > The patch saves few instructions but makes the code less readable a bit. Do you find advices applicable from another information source also for this function implementation? https://wiki.sei.cmu.edu/confluence/display/c/MEM12-C.+Consider+using+a+goto+chain+when+leaving+a+function+on+error+when+using+and+releasing+resources Regards, Markus
