Hi Markus, kernel test robot noticed the following build warnings: [auto build test WARNING on net/main] [also build test WARNING on net-next/main linus/master v6.7-rc7 next-20231222] [cannot apply to horms-ipvs/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Markus-Elfring/net-smc-Return-directly-after-a-failed-kzalloc-in-smc_fill_gid_list/20231231-231406 base: net/main patch link: https://lore.kernel.org/r/5253e660-6b66-4775-ae2f-06f5a1d40be5%40web.de patch subject: [PATCH 2/2] net/smc: Improve exception handling in smc_llc_cli_add_link_invite() config: x86_64-randconfig-002-20231231 (https://download.01.org/0day-ci/archive/20240101/202401010536.XhzcWDPH-lkp@xxxxxxxxx/config) compiler: ClangBuiltLinux clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240101/202401010536.XhzcWDPH-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202401010536.XhzcWDPH-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): >> net/smc/smc_llc.c:1175:34: warning: '&&' within '||' [-Wlogical-op-parentheses] 1174 | lgr->type == SMC_LGR_ASYMMETRIC_PEER || | ~~ 1175 | lgr->type == SMC_LGR_SINGLE && lgr->max_links <= 1) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ net/smc/smc_llc.c:1175:34: note: place parentheses around the '&&' expression to silence this warning 1175 | lgr->type == SMC_LGR_SINGLE && lgr->max_links <= 1) | ^ | ( ) 1 warning generated. vim +1175 net/smc/smc_llc.c 1160 1161 /* as an SMC client, invite server to start the add_link processing */ 1162 static void smc_llc_cli_add_link_invite(struct smc_link *link, 1163 struct smc_llc_qentry *qentry) 1164 { 1165 struct smc_link_group *lgr = smc_get_lgr(link); 1166 struct smc_init_info *ini; 1167 1168 if (lgr->smc_version == SMC_V2) { 1169 smc_llc_send_request_add_link(link); 1170 goto free_qentry; 1171 } 1172 1173 if (lgr->type == SMC_LGR_SYMMETRIC || 1174 lgr->type == SMC_LGR_ASYMMETRIC_PEER || > 1175 lgr->type == SMC_LGR_SINGLE && lgr->max_links <= 1) 1176 goto free_qentry; 1177 1178 ini = kzalloc(sizeof(*ini), GFP_KERNEL); 1179 if (!ini) 1180 goto free_qentry; 1181 1182 ini->vlan_id = lgr->vlan_id; 1183 smc_pnet_find_alt_roce(lgr, ini, link->smcibdev); 1184 if (!ini->ib_dev) 1185 goto out; 1186 1187 smc_llc_send_add_link(link, ini->ib_dev->mac[ini->ib_port - 1], 1188 ini->ib_gid, NULL, SMC_LLC_REQ); 1189 out: 1190 kfree(ini); 1191 free_qentry: 1192 kfree(qentry); 1193 } 1194 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
