On Sun 10-12-23 18:32:18, Christophe JAILLET wrote:
> ida_alloc() and ida_free() should be preferred to the deprecated
> ida_simple_get() and ida_simple_remove().
>
> This is less verbose.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@xxxxxxx>
Honza
> ---
> fs/eventfd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/eventfd.c b/fs/eventfd.c
> index 16bea05a7c78..ad8186d47ba7 100644
> --- a/fs/eventfd.c
> +++ b/fs/eventfd.c
> @@ -82,7 +82,7 @@ EXPORT_SYMBOL_GPL(eventfd_signal_mask);
> static void eventfd_free_ctx(struct eventfd_ctx *ctx)
> {
> if (ctx->id >= 0)
> - ida_simple_remove(&eventfd_ida, ctx->id);
> + ida_free(&eventfd_ida, ctx->id);
> kfree(ctx);
> }
>
> @@ -395,7 +395,7 @@ static int do_eventfd(unsigned int count, int flags)
> init_waitqueue_head(&ctx->wqh);
> ctx->count = count;
> ctx->flags = flags;
> - ctx->id = ida_simple_get(&eventfd_ida, 0, 0, GFP_KERNEL);
> + ctx->id = ida_alloc(&eventfd_ida, GFP_KERNEL);
>
> flags &= EFD_SHARED_FCNTL_FLAGS;
> flags |= O_RDWR;
> --
> 2.34.1
>
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
