Hi, On Sat, Nov 25, 2023 at 4:05 AM Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> wrote: > > When appending "[defcmd]" to 'kdb_prompt_str', the size of the string > already in the buffer should be taken into account. > > An option could be to switch from strncat() to strlcat() which does the > correct test to avoid such an overflow. > > However, this actually looks as dead code, because 'defcmd_in_progress' > can't be true here. > See a more detailed explanation at [1]. > > [1]: https://lore.kernel.org/all/CAD=FV=WSh7wKN7Yp-3wWiDgX4E3isQ8uh0LCzTmd1v9Cg9j+nQ@xxxxxxxxxxxxxx/ > > Fixes: 5d5314d6795f ("kdb: core for kgdb back end (1 of 2)") > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> > --- > Changes in v2: > - Delete the strncat() call [Doug Anderson] > > v1: https://lore.kernel.org/all/0b1790ca91b71e3362a6a4c2863bc5787b4d60c9.1698501284.git.christophe.jaillet@xxxxxxxxxx/ > --- > kernel/debug/kdb/kdb_main.c | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
