On 27.11.2023 13:59, Dan Carpenter wrote:
> Set the "err" variable on this error path.
>
> Fixes: fff292b47ac1 ("ice: add VF representors one by one")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
Thanks Dan!
Reviewed-by: Wojciech Drewek <wojciech.drewek@xxxxxxxxx>
> drivers/net/ethernet/intel/ice/ice_eswitch.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_eswitch.c b/drivers/net/ethernet/intel/ice/ice_eswitch.c
> index 3f80e2081e5d..ca118bc37e44 100644
> --- a/drivers/net/ethernet/intel/ice/ice_eswitch.c
> +++ b/drivers/net/ethernet/intel/ice/ice_eswitch.c
> @@ -669,8 +669,10 @@ ice_eswitch_attach(struct ice_pf *pf, struct ice_vf *vf)
> ice_eswitch_stop_reprs(pf);
>
> repr = ice_repr_add_vf(vf);
> - if (IS_ERR(repr))
> + if (IS_ERR(repr)) {
> + err = PTR_ERR(repr);
> goto err_create_repr;
> + }
>
> err = ice_eswitch_setup_repr(pf, repr);
> if (err)
