On 2023/11/13 14:43, Jason Yan wrote:
On 2023/11/13 14:32, Su Hui wrote:
On 2023/11/13 13:56, Jason Yan wrote:
Hi, Su
On 2023/11/13 13:01, Su Hui wrote:
Clang static analyzer complains that value stored to 'res' is never
read.
Return the error code when sas_find_attached_phy_id() failed.
Fixes: ec64858657a8 ("scsi: pm8001: Use sas_find_attached_phy_id()
instead of open coding it")
This 'Fixes' tag is not right. This commit is only a refactor and
did not change the original logic here.
Hi, Jason
Thanks for your reply. But I think the logic of this code is changed.
I,m talking about the Fixes tag: ec64858657a8 ("scsi: pm8001: Use
sas_find_attached_phy_id() instead of open coding it"
That commit did not change the original logic. So your patch is not
fixing that commit.
Oh, got it.
Really thanks for your reminder! I will send v2 patch soon:).
Su Hui
