Re: [PATCH 1/2] scsi: scsi_debug: fix some bugs in sdebug_error_write()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Wenchao Hao <haowenchao22@xxxxxxxxx>
Subject: Re: [PATCH 1/2] scsi: scsi_debug: fix some bugs in sdebug_error_write()
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Mon, 6 Nov 2023 16:44:16 +0300
Cc: Wenchao Hao <haowenchao2@xxxxxxxxxx>, Eugeniy Paltsev <Eugeniy.Paltsev@xxxxxxxxxxxx>, Vinod Koul <vkoul@xxxxxxxxxx>, "James E.J. Bottomley" <jejb@xxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Douglas Gilbert <dgilbert@xxxxxxxxxxxx>, dmaengine@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx
In-reply-to: <65b8f53d-4956-4440-bd4c-66475015aaff@gmail.com>
References: <96d50cf7-afec-46af-9d98-08099f8dc76e@moroto.mountain> <CAOptpSMTgGwyFkn8o6qAEnUKXh+_mOr8dQKAZUWfM_4QEnxzxw@mail.gmail.com> <44b0eca3-57c1-4edd-ab35-c389dc976273@kadam.mountain> <cbe14e3a-11c7-4da5-b125-5801244e27f2@gmail.com> <9767953c-480d-4ad9-a553-a45ae80c572b@kadam.mountain> <afe1eca8-cdf8-612b-867e-4fef50ad423f@huawei.com> <9207ed62-4e41-4b8c-8aee-5143c1a71bf8@kadam.mountain> <65b8f53d-4956-4440-bd4c-66475015aaff@gmail.com>

Oh.  Duh.  The issue is that echo doesn't actually put a NUL terminator
on the end of the string...  Let's go with kzalloc(count + 1, as you
suggest.

regards,
dan carpenter

References:
- [PATCH 1/2] scsi: scsi_debug: fix some bugs in sdebug_error_write()
  - From: Dan Carpenter
- Re: [PATCH 1/2] scsi: scsi_debug: fix some bugs in sdebug_error_write()
  - From: Wenchao Hao
- Re: [PATCH 1/2] scsi: scsi_debug: fix some bugs in sdebug_error_write()
  - From: Dan Carpenter
- Re: [PATCH 1/2] scsi: scsi_debug: fix some bugs in sdebug_error_write()
  - From: Wenchao Hao
- Re: [PATCH 1/2] scsi: scsi_debug: fix some bugs in sdebug_error_write()
  - From: Dan Carpenter
- Re: [PATCH 1/2] scsi: scsi_debug: fix some bugs in sdebug_error_write()
  - From: Wenchao Hao
- Re: [PATCH 1/2] scsi: scsi_debug: fix some bugs in sdebug_error_write()
  - From: Dan Carpenter
- Re: [PATCH 1/2] scsi: scsi_debug: fix some bugs in sdebug_error_write()
  - From: Wenchao Hao

Prev by Date: Re: [PATCH v2 1/2] pwm: samsung: Fix a bit test in pwm_samsung_resume()
Next by Date: Re: [PATCH] net: bcmasp: Use common error handling code in bcmasp_probe()
Previous by thread: Re: [PATCH 1/2] scsi: scsi_debug: fix some bugs in sdebug_error_write()
Next by thread: [PATCH] fbdev/offb: Simplify offb_init_fb()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]