On Mon, Oct 30, 2023 at 12:03:12PM +0300, Dan Carpenter wrote: > The apple_dart_domain_alloc_paging() function is supposed to return NULL > on error. Returning an error pointer will lead to an Oops in > __iommu_domain_alloc(). > > Fixes: 482feb5c6492 ("iommu/dart: Call apple_dart_finalize_domain() as part of alloc_paging()") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > --- > drivers/iommu/apple-dart.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx> Really need to fix this so the function does return ERR_PTR.. Thanks, Jason