On Fri, Oct 20, 2023 at 05:00:04PM +0800, Su Hui wrote: > mv88e6xxx_tai_write() can return error code (-EOPNOTSUPP ...) if failed. > So check the value of 'ret' after calling mv88e6xxx_tai_write(). > > Signed-off-by: Su Hui <suhui@xxxxxxxxxxxx> > --- mv88e6xxx_avb_ops :: tai_read() and tai_write() come in pairs for the existing implementations. So, a missing tai_write() method also implies a missing tai_read() and would have been caught by the previous call to mv88e6xxx_tai_read() in this function. But, ok. Reviewed-by: Vladimir Oltean <vladimir.oltean@xxxxxxx> This is a patch for net-next, as it doesn't fix any user-visible issue and is just an improvement. For future changes, please note your expectation regarding the target tree yourself, by formatting the patch as "[PATCH net-next]".
