Re: [PATCH] media: qcom: camss: clean up a check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dan Carpenter <dan.carpenter@xxxxxxxxxx>, Robert Foss <rfoss@xxxxxxxxxx>
Subject: Re: [PATCH] media: qcom: camss: clean up a check
From: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
Date: Thu, 12 Oct 2023 18:13:19 +0200
Cc: Todor Tomov <todor.too@xxxxxxxxx>, "Bryan O'Donoghue" <bryan.odonoghue@xxxxxxxxxx>, Andy Gross <agross@xxxxxxxxxx>, Bjorn Andersson <andersson@xxxxxxxxxx>, Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>, linux-media@xxxxxxxxxxxxxxx, linux-arm-msm@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx
In-reply-to: <f11b1d6b-5800-4d75-9732-506be3f8458d@moroto.mountain>
References: <f11b1d6b-5800-4d75-9732-506be3f8458d@moroto.mountain>
User-agent: Mozilla Thunderbird



On 10/12/23 11:42, Dan Carpenter wrote:

Imagine that "->vfe_num" is zero, then the subtraction will underflow to
UINT_MAX.  Plus it's just cleaner to use >= instead.

Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
---

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Konrad

References:
- [PATCH] media: qcom: camss: clean up a check
  - From: Dan Carpenter

Prev by Date: Re: [PATCH] hardening: x86: drop reference to removed config AMD_IOMMU_V2
Next by Date: Re: [PATCH] clk: stm32: Fix a signedness issue in clk_stm32_composite_determine_rate()
Previous by thread: Re: [PATCH] media: qcom: camss: clean up a check
Next by thread: [PATCH] drm/msm: remove unnecessary NULL check
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]

Powered by Linux