Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@xxxxxxxxxx>: On Fri, 8 Sep 2023 10:03:37 +0300 you wrote: > The vcap_decode_rule() never returns NULL. There is no need to check > for that. This code assumes that if it did return NULL we should > end abruptly and return success. It is confusing. Fix the check to > just be if (IS_ERR()) instead of if (IS_ERR_OR_NULL()). > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Closes: https://lore.kernel.org/r/202309070831.hTvj9ekP-lkp@xxxxxxxxx/ > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > [...] Here is the summary with links: - [net-next] net: microchip: sparx5: clean up error checking in vcap_show_admin() https://git.kernel.org/netdev/net-next/c/788f63c4dc17 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
