On Wed, Sep 27, 2023 at 03:53:37PM +0300, Dan Carpenter wrote:
> Smatch complains that if "src_idx" equals "dst_idx" then
> ksz9477_validate_and_get_src_count() doesn't initialized "src_count".
> Set it to zero for this situation.
>
> Fixes: 002841be134e ("net: dsa: microchip: Add partial ACL support for ksz9477 switches")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Reviewed-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
Thank you!
> ---
> drivers/net/dsa/microchip/ksz9477_acl.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/microchip/ksz9477_acl.c b/drivers/net/dsa/microchip/ksz9477_acl.c
> index 06d74c19eb94..e554cd4a024b 100644
> --- a/drivers/net/dsa/microchip/ksz9477_acl.c
> +++ b/drivers/net/dsa/microchip/ksz9477_acl.c
> @@ -554,7 +554,8 @@ static int ksz9477_acl_move_entries(struct ksz_device *dev, int port,
> struct ksz9477_acl_entry buffer[KSZ9477_ACL_MAX_ENTRIES];
> struct ksz9477_acl_priv *acl = dev->ports[port].acl_priv;
> struct ksz9477_acl_entries *acles = &acl->acles;
> - int src_count, ret, dst_count;
> + int ret, dst_count;
> + int src_count = 0;
>
> ret = ksz9477_validate_and_get_src_count(dev, port, src_idx, dst_idx,
> &src_count, &dst_count);
> --
> 2.39.2
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
