Re: [PATCH 2/3 net] net: ti: icssg-prueth: Fix signedness bug in prueth_init_tx_chns()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Subject: Re: [PATCH 2/3 net] net: ti: icssg-prueth: Fix signedness bug in prueth_init_tx_chns()
From: Roger Quadros <rogerq@xxxxxx>
Date: Wed, 27 Sep 2023 14:29:12 +0300
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, MD Danish Anwar <danishanwar@xxxxxx>, Andrew Lunn <andrew@xxxxxxx>, Grygorii Strashko <grygorii.strashko@xxxxxx>, "Vignesh Raghavendra" <vigneshr@xxxxxx>, <netdev@xxxxxxxxxxxxxxx>, <kernel-janitors@xxxxxxxxxxxxxxx>
In-reply-to: <34770474-0345-4223-9c11-9039b74d03b4@moroto.mountain>
References: <34770474-0345-4223-9c11-9039b74d03b4@moroto.mountain>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0



On 26.9.2023 17.05, Dan Carpenter wrote:

The "tx_chn->irq" variable is unsigned so the error checking does not
work correctly.

Fixes: 128d5874c082 ("net: ti: icssg-prueth: Add ICSSG ethernet driver")
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>


Reviewed-by: Roger Quadros <rogerq@xxxxxxxxxx>

References:
- [PATCH 2/3 net] net: ti: icssg-prueth: Fix signedness bug in prueth_init_tx_chns()
  - From: Dan Carpenter

Prev by Date: Re: [PATCH next] cgroup/cpuset: Cleanup signedness issue in cpu_exclusive_check()
Next by Date: [PATCH] ACPI: thermal: Fix a small leak in acpi_thermal_add()
Previous by thread: [PATCH 2/3 net] net: ti: icssg-prueth: Fix signedness bug in prueth_init_tx_chns()
Next by thread: [PATCH 3/3 net] dmaengine: ti: k3-udma-glue: clean up k3_udma_glue_tx_get_irq() return
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]