smatch error: fs/ntfs3/attrib.c:1826 attr_allocate_frame() error: we previously assumed 'attr_b' could be null (see line 1739) Return error code directly if 'attr_b' is NULL. Signed-off-by: Su Hui <suhui@xxxxxxxxxxxx> --- fs/ntfs3/attrib.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/ntfs3/attrib.c b/fs/ntfs3/attrib.c index a9d82bbb4729..ebc934ac5cf5 100644 --- a/fs/ntfs3/attrib.c +++ b/fs/ntfs3/attrib.c @@ -1737,8 +1737,7 @@ int attr_allocate_frame(struct ntfs_inode *ni, CLST frame, size_t compr_size, attr_b = ni_find_attr(ni, NULL, &le_b, ATTR_DATA, NULL, 0, NULL, &mi_b); if (!attr_b) { - err = -ENOENT; - goto out; + return -ENOENT; } attr = attr_b; -- 2.30.2