On Fri, Sep 08, 2023 at 10:03:37AM +0300, Dan Carpenter wrote: > The vcap_decode_rule() never returns NULL. There is no need to check > for that. This code assumes that if it did return NULL we should > end abruptly and return success. It is confusing. Fix the check to > just be if (IS_ERR()) instead of if (IS_ERR_OR_NULL()). > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Closes: https://lore.kernel.org/r/202309070831.hTvj9ekP-lkp@xxxxxxxxx/ > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > --- > This bug is old, but it doesn't affect runtime so it should go to > net-next. Reviewed-by: Simon Horman <horms@xxxxxxxxxx>
