On Wed, Sep 06, 2023 at 11:58:28PM +0100, Edward Cree wrote: > On 06/09/2023 12:55, Dan Carpenter wrote: > > rhashtable_lookup_get_insert_fast() can return NULL or error pointers. > > So it can! Thanks for catching this. > Looking at the rest of the driver, it appears quite a few other calls > to this function also assume it returns only valid ptr or NULL. > I'll audit them all and produce a patch, with your Reported-by if > that's okay? Yes, please! Thanks. regars, dan carpenter