On Wed, Aug 02, 2023 at 09:57:37AM -0700, Boqun Feng wrote: > > Thanks for reporting this. However the "bug" is by design, > locking-selftest.c contains tests that trigger incorrect lock usages and > see if lockdep can catch them, so it's supposed to work in that way. > > Out of curiosity, could Smatch detect the same issue without the patch? > The patch is simply a cleanup, so no functional change, in theory, the > "bug" can be detected without that patch. > Yeah. It's just that the warnings show up as new to me when functions are renamed. regards dan carpenter