RE: [PATCH net] net: ll_temac: fix error checking of irq_of_parse_and_map()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Sent: Monday, July 31, 2023 1:13 PM
> To: Esben Haabendal <esben@xxxxxxxxxx>
> Cc: David S. Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet
> <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni
> <pabeni@xxxxxxxxxx>; Simek, Michal <michal.simek@xxxxxxx>; Katakam,
> Harini <harini.katakam@xxxxxxx>; Haoyue Xu <xuhaoyue1@xxxxxxxxxxxxx>;
> huangjunxian <huangjunxian6@xxxxxxxxxxxxx>; Yang Yingliang
> <yangyingliang@xxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>;
> netdev@xxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx
> Subject: [PATCH net] net: ll_temac: fix error checking of
> irq_of_parse_and_map()
> 
> Most kernel functions return negative error codes but some irq functions
> return zero on error.  In this code irq_of_parse_and_map(), returns zero
> and platform_get_irq() returns negative error codes.  We need to handle
> both cases appropriately.
> 
> Fixes: 8425c41d1ef7 ("net: ll_temac: Extend support to non-device-tree
> platforms")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Thanks,
Reviewed-by: Harini Katakam <harini.katakam@xxxxxxx>

Regards,
Harini




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux