Hi Christophe,
I will submit individual patches to address memory leaks and uninitialized variable errors for each source file listed below.
> hp_populate_string_elements_from_package
drivers/platform/x86/hp/hp-bioscfg/string-attributes.c
> hp_populate_ordered_list_elements_from_package()
drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c
> hp_populate_integer_elements_from_package()
drivers/platform/x86/hp/hp-bioscfg/int-attributes.c
> hp_populate_enumeration_elements_from_package()
drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c
> hp_populate_password_elements_from_package()
drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c
Regards,
Jorge Lopez
HP Inc
“Once you stop learning, you start dying”
Albert Einstein
> -----Original Message-----
> From: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> Sent: Tuesday, July 18, 2023 12:37 PM
> To: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Cc: Lopez, Jorge A (Security) <jorge.lopez2@xxxxxx>; Hans de Goede
> <hdegoede@xxxxxxxxxx>; Mark Gross <markgross@xxxxxxxxxx>; Thomas
> Weißschuh <linux@xxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; kernel-
> janitors@xxxxxxxxxxxxxxx; platform-driver-x86@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] platform/x86: hp-bioscfg: Fix some memory leaks in
> hp_populate_enumeration_elements_from_package()
>
> CAUTION: External Email
>
> Le 18/07/2023 à 09:55, Dan Carpenter a écrit :
> > On Mon, Jul 17, 2023 at 10:53:37PM +0200, Christophe JAILLET wrote:
> >> In the loop in the ENUM_POSSIBLE_VALUES case, we allocate some
> memory
> >> that is never freed.
> >>
> >> While at it, add some "str_value = NULL" to avoid some potential
> >> double free.
> >>
> >> Fixes: 6b2770bfd6f9 ("platform/x86: hp-bioscfg: enum-attributes")
> >> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> >> ---
> >> /!\ Speculative /!\
> >>
> >> This patch is based on analysis of the surrounding code and should be
> >> reviewed with care !
> >>
> >> /!\ Speculative /!\
> >
> > I reported these bugs yesterday.
>
> Ok, seen now...
> ... but I don't read platform-driver-x86@xxxxxxxxxxxxxxx :)
>
> CJ
>
> > I don't think this is the correct fix.
> > I thought about making the str_value local to the for loop. That's
> > sort of like what your patch does. But I wasn't sure that was
> > necessarily correct either.
> >
> > This code needs more testing as well. It seems no one has called this
> > function.
> >
> > Smatch complained about uninitialized variables as well. I didn't
> > bother to report that yesterday but I may as well.
> >
> > regards,
> > dan carpenter
> >
> > drivers/platform/x86/hp/hp-bioscfg/string-attributes.c:188
> hp_populate_string_elements_from_package() error: uninitialized symbol
> 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/string-attributes.c:191
> hp_populate_string_elements_from_package() error: uninitialized symbol
> 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/string-attributes.c:194
> hp_populate_string_elements_from_package() error: uninitialized symbol
> 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/string-attributes.c:197
> hp_populate_string_elements_from_package() error: uninitialized symbol
> 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/string-attributes.c:200
> hp_populate_string_elements_from_package() error: uninitialized symbol
> 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/string-attributes.c:239
> hp_populate_string_elements_from_package() error: uninitialized symbol
> 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/string-attributes.c:242
> hp_populate_string_elements_from_package() error: uninitialized symbol
> 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/string-attributes.c:245
> hp_populate_string_elements_from_package() error: uninitialized symbol
> 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c:192
> hp_populate_ordered_list_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c:195
> hp_populate_ordered_list_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c:198
> hp_populate_ordered_list_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c:201
> hp_populate_ordered_list_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c:204
> hp_populate_ordered_list_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c:238
> hp_populate_ordered_list_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c:242
> hp_populate_ordered_list_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c:262
> hp_populate_ordered_list_elements_from_package() error: uninitialized
> symbol 'value_len'.
> > drivers/platform/x86/hp/hp-bioscfg/int-attributes.c:198
> hp_populate_integer_elements_from_package() error: uninitialized symbol
> 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/int-attributes.c:201
> hp_populate_integer_elements_from_package() error: uninitialized symbol
> 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/int-attributes.c:204
> hp_populate_integer_elements_from_package() error: uninitialized symbol
> 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/int-attributes.c:207
> hp_populate_integer_elements_from_package() error: uninitialized symbol
> 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/int-attributes.c:246
> hp_populate_integer_elements_from_package() error: uninitialized symbol
> 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/int-attributes.c:249
> hp_populate_integer_elements_from_package() error: uninitialized symbol
> 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/int-attributes.c:252
> hp_populate_integer_elements_from_package() error: uninitialized symbol
> 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/int-attributes.c:255
> hp_populate_integer_elements_from_package() error: uninitialized symbol
> 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c:180
> hp_populate_enumeration_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c:183
> hp_populate_enumeration_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c:186
> hp_populate_enumeration_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c:189
> hp_populate_enumeration_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c:192
> hp_populate_enumeration_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c:231
> hp_populate_enumeration_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c:239
> hp_populate_enumeration_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:279
> hp_populate_password_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:282
> hp_populate_password_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:285
> hp_populate_password_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:288
> hp_populate_password_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:291
> hp_populate_password_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:324
> hp_populate_password_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:327
> hp_populate_password_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:330
> hp_populate_password_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:333
> hp_populate_password_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:362
> hp_populate_password_elements_from_package() error: uninitialized
> symbol 'int_value'.
> >
