Reviewed-by: Jorge Lopez <jorge.lopez2@xxxxxx>
Regards,
Jorge Lopez
HP Inc
"Once you stop learning, you start dying"
Albert Einstein
> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Sent: Tuesday, July 18, 2023 2:06 AM
> To: Lopez, Jorge A (Security) <jorge.lopez2@xxxxxx>
> Cc: Hans de Goede <hdegoede@xxxxxxxxxx>; Mark Gross
> <markgross@xxxxxxxxxx>; Thomas Weißschuh <linux@xxxxxxxxxxxxxx>;
> platform-driver-x86@xxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx
> Subject: [PATCH 3/3] platform/x86: hp-bioscfg: fix error reporting in
> hp_add_other_attributes()
>
> CAUTION: External Email
>
> Return a negative error code instead of returning success.
>
> Fixes: a34fc329b189 ("platform/x86: hp-bioscfg: bioscfg")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c
> b/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c
> index 32d9c36ca553..8c4f9e12f018 100644
> --- a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c
> +++ b/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c
> @@ -630,13 +630,18 @@ static int hp_add_other_attributes(int attr_type)
> switch (attr_type) {
> case HPWMI_SECURE_PLATFORM_TYPE:
> ret = hp_populate_secure_platform_data(attr_name_kobj);
> + if (ret)
> + goto err_other_attr_init;
> break;
>
> case HPWMI_SURE_START_TYPE:
> ret = hp_populate_sure_start_data(attr_name_kobj);
> + if (ret)
> + goto err_other_attr_init;
> break;
>
> default:
> + ret = -EINVAL;
> goto err_other_attr_init;
> }
>
> --
> 2.39.2
