Hello Dan,
On Tue, Jul 25, 2023 at 09:50:55AM +0300, Dan Carpenter wrote:
> This is passing a NULL thread to request_threaded_irq(). So it's not
> really a threaded IRQ at all. It's more readable to call request_irq()
> instead.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> drivers/i2c/busses/i2c-imx.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> index 65128a73e8a3..c0cac5bcfdd1 100644
> --- a/drivers/i2c/busses/i2c-imx.c
> +++ b/drivers/i2c/busses/i2c-imx.c
> @@ -1506,8 +1506,7 @@ static int i2c_imx_probe(struct platform_device *pdev)
> goto rpm_disable;
>
> /* Request IRQ */
> - ret = request_threaded_irq(irq, i2c_imx_isr, NULL, IRQF_SHARED,
> - pdev->name, i2c_imx);
> + ret = request_irq(irq, i2c_imx_isr, IRQF_SHARED, pdev->name, i2c_imx);
> if (ret) {
> dev_err(&pdev->dev, "can't claim irq %d\n", irq);
> goto rpm_disable;
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
There are a few more drivers that could benefit from the same patch
(i.e.
drivers/gpu/drm/bridge/samsung-dsim.c
drivers/iio/magnetometer/bmc150_magn.c
drivers/scsi/mpi3mr/mpi3mr_fw.c
drivers/spi/spi-fsl-dspi.c
as of today's next).
I assume you care for these, too?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
