Hi Dan, On 7/24/23 22:39, Dan Carpenter wrote: > These functions returns type bool, not pointers, so return false instead > of NULL. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> LGTM. Thanks. Reviewed-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > --- > Not a bug. Targetting net-next. > > drivers/net/ethernet/mellanox/mlx4/mcg.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx4/mcg.c b/drivers/net/ethernet/mellanox/mlx4/mcg.c > index f1716a83a4d3..24d0c7c46878 100644 > --- a/drivers/net/ethernet/mellanox/mlx4/mcg.c > +++ b/drivers/net/ethernet/mellanox/mlx4/mcg.c > @@ -294,7 +294,7 @@ static bool check_duplicate_entry(struct mlx4_dev *dev, u8 port, > struct mlx4_promisc_qp *dqp, *tmp_dqp; > > if (port < 1 || port > dev->caps.num_ports) > - return NULL; > + return false; > > s_steer = &mlx4_priv(dev)->steer[port - 1]; > > @@ -375,7 +375,7 @@ static bool can_remove_steering_entry(struct mlx4_dev *dev, u8 port, > bool ret = false; > > if (port < 1 || port > dev->caps.num_ports) > - return NULL; > + return false; > > s_steer = &mlx4_priv(dev)->steer[port - 1]; > -- ~Randy
