On 2023/7/19 15:22, Huacai Chen wrote:
Hi, Markus,
On Wed, Jul 19, 2023 at 2:51 PM Markus Elfring <Markus.Elfring@xxxxxx> wrote:
…, so this patch add
some code to fix it.
Would you like to avoid a typo here?
Will any other imperative change description variant become more helpful?
Thank you for pointing this out, but since Zhihong is the original
author, I don't want to completely rewrite the commit message, so just
fix the typo...
AFAICT the commit message is totally uninformative even if "an
imperative change description" were used. It basically:
1. repeated the patch title,
2. spent one sentence only for mentioning a function name without giving
any more information,
3. mentioned why some change was not necessary due to some other
existing code, but not explicitly calling that part out, then
4. finished with a sentence that boiled down to "we should do the
similar thing".
My take:
> Subject: Fix CMDLINE_EXTEND and CMDLINE_BOOTLOADER on non-FDT systems
>
> On FDT systems these command line processing are already taken care of
> by early_init_dt_scan_chosen(). Add similar handling to the non-FDT
> code path to allow these config options to work for non-FDT boxes too.
Would this sound better?
--
WANG "xen0n" Xuerui
Linux/LoongArch mailing list: https://lore.kernel.org/loongarch/
