On 7/17/23 23:38, Mark Brown wrote:
> On Mon, Jul 17, 2023 at 07:55:05PM +0200, Christophe JAILLET wrote:
>> All error handling paths go to 'out', except this one. Be consistent and
>> also branch to 'out' here.
>
> This looks like a reasonable cleanup.
>
> Reviewed-by: Mark Brown <broonie@xxxxxxxxxx>
Reviewed-by: Anshuman Khandual <anshuman.khandual@xxxxxxx>
>
>> Fixes: e12310a0d30f ("arm64/sme: Implement ptrace support for streaming mode SVE registers")
>
>> default:
>> WARN_ON_ONCE(1);
>> - return -EINVAL;
>> + ret = -EINVAL;
>> + goto out;
>> }
>
> It's not exactly a fix though (probably not worth backporting for
+1
> example, which tends to get keyed off the fixes tag) since something's
> incredibly confused if this code path ever gets executed, we're setting
> an unknown SVE vector type hence the WARN_ON() there.
Agreed.
