On Thu, Jul 06, 2023 at 08:21:35AM +0200, Christian König wrote: > Am 06.07.23 um 07:52 schrieb Dan Carpenter: > > The __dma_fence_unwrap_merge() function is supposed to return NULL on > > error. But the dma_fence_allocate_private_stub() returns error pointers > > so check for that and covert the error pointers to NULL returns. > > Otherwise, the callers do not expect error pointers and it leads to an > > Oops. > > Oh, good catch. > > But I think we should probably change dma_fence_allocate_private_stub() > instead, that this function returns an ERR_PTR doesn't seem to make to much > sense. Sure, I've sent v2. regards, dan carpenter