On Wed, Jul 05, 2023 at 08:21:02PM +0200, Markus Elfring wrote: > Please apply a more appropriate patch subject. > Markus, a number of people have asked you to stop with this nonsense. > > > The devm_memremap() function returns error pointers. > > It never returns NULL. Fix the check. > > Would the following wording be helpful? > > > Replace a null pointer check by an error pointer check after a call > of the function “devm_memremap” in this function implementation. No. The original was fine. The original commit message is more clear than your proposed commit message. regards, dan carpenter
