Re: [PATCH net] mlxsw: spectrum_router: Fix an IS_ERR() vs NULL check

[Alexander Lobakin <aleksander.lobakin@xxxxxxxxx>]

From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Mon, 3 Jul 2023 18:24:52 +0300

> The mlxsw_sp_crif_alloc() function returns NULL on error.  It doesn't
> return error pointers.  Fix the check.
> 
> Fixes: 78126cfd5dc9 ("mlxsw: spectrum_router: Maintain CRIF for fallback loopback RIF")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Reviewed-by: Alexander Lobakin <aleksander.lobakin@xxxxxxxxx>

> ---
> Applies to net.
> 
>  drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

[...]

Thanks,
Olek