Hi Markus, On 02.07.23 18:55, Markus Elfring wrote: >> The rename should reduce this confusion. > > Would the wording “Reduce this confusion by renaming a variable at three places” > be more appropriate for a subsequent change description? > > See also: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4#n94 Thanks for pointing that out (also in your other mail for this series). I will be more careful regarding the use of imperative mood. > >> Since it is a pure >> rename, it has no impact on functionality. >> >> Fixes: e17090eb2494 ("igc: allow BaseTime 0 enrollment for Qbv") > > How does such information fit together? The referenced commit introduced an issue into the kernel by introducing a variable that does not exactly describe its actual purpose. It is not only a cosmetic change, but in my view this confusion was related to other issues (see the other patches). So, it seemed to be worth fixing alongside with the other fixes, even if it does not directly impact functionality if it is applied or not (until someone else comes along, also gets confused and introduces another bug...). Thanks, Florian
