On 2023/6/29 13:50, Dan Carpenter wrote:
On Thu, Jun 29, 2023 at 09:59:56AM +0800, yunchuan wrote:
On 2023/6/28 17:50, Russell King (Oracle) wrote:
On Wed, Jun 28, 2023 at 10:45:17AM +0800, wuych wrote:
@@ -211,7 +211,7 @@ static void xgene_enet_wr_mdio_csr(void __iomem *base_addr,
static int xgene_xfi_mdio_write(struct mii_bus *bus, int phy_id,
int reg, u16 data)
{
- void __iomem *addr = (void __iomem *)bus->priv;
+ void __iomem *addr = bus->priv;
int timeout = 100;
u32 status, val;
@@ -234,7 +234,7 @@ static int xgene_xfi_mdio_write(struct mii_bus *bus, int phy_id,
static int xgene_xfi_mdio_read(struct mii_bus *bus, int phy_id, int reg)
{
- void __iomem *addr = (void __iomem *)bus->priv;
+ void __iomem *addr = bus->priv;
u32 data, status, val;
int timeout = 100;
These probably cause Sparse to warn whether or not the cast is there.
Hi, Russell King,
I didn't notice this Sparse warning.
Should I remove this cast although it cause Sparse warning?
No. Don't introduce new Sparse warnings.
Got it, thanks for your answer!
wuych
regards,
dan carpenter
