On 2023/6/28 10:45, wuych wrote:
> Pointer variables of void * type do not require type cast.
>
> Signed-off-by: wuych <yunchuan@xxxxxxxxxxxx>
> ---
> drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
> index 51d1278b18f6..1df941ef86e3 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
> @@ -570,7 +570,7 @@ static void hns3_get_strings(struct net_device *netdev, u32 stringset, u8 *data)
>
> static u64 *hns3_get_stats_tqps(struct hnae3_handle *handle, u64 *data)
> {
> - struct hns3_nic_priv *nic_priv = (struct hns3_nic_priv *)handle->priv;
> + struct hns3_nic_priv *nic_priv = handle->priv;
> struct hnae3_knic_private_info *kinfo = &handle->kinfo;
> struct hns3_enet_ring *ring;
> u8 *stat;
>
Hi wuych,
Thank you for your patch.
nit: the local variable declarations could be reverse xmas tree
longest line to shortest line. One option being:
static u64 *hns3_get_stats_tqps(struct hnae3_handle *handle, u64 *data)
{
- struct hns3_nic_priv *nic_priv = (struct hns3_nic_priv *)handle->priv;
struct hnae3_knic_private_info *kinfo = &handle->kinfo;
+ struct hns3_nic_priv *nic_priv = handle->priv;
struct hns3_enet_ring *ring;
u8 *stat;
and elsewhere in other patchs.
By the way, the net-next branch is currently closed, and you need to wait for
the merge window to open before merging patches.
Reviewed-by: Hao Lan <lanhao@xxxxxxxxxx>
Yours,
Hao Lan
