On Mon, 12 Jun 2023 22:13:37 +0200 Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> wrote: > There is no need to include i2c.h and spi/spi.h in st_sensors.h. > Should it be needed, st_sensors_(i2c|spi).h should be used. Agreed these should be dropped from here. But I don't agree with statement that i2c.h and spi/spi.h should be gotten implicitly from st_sensors_i2c.h / st_sensors_spi.h If they are needed the should be included directly in the files where they are needed. Jonathan > > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> > --- > Based on one of my script, this reduces the number of included files from > 573 files to 515 files when compiling drivers/iio/accel/st_accel_buffer.c > --- > include/linux/iio/common/st_sensors.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/linux/iio/common/st_sensors.h b/include/linux/iio/common/st_sensors.h > index 607c3a89a647..a1d3d57d6d6e 100644 > --- a/include/linux/iio/common/st_sensors.h > +++ b/include/linux/iio/common/st_sensors.h > @@ -10,8 +10,6 @@ > #ifndef ST_SENSORS_H > #define ST_SENSORS_H > > -#include <linux/i2c.h> > -#include <linux/spi/spi.h> > #include <linux/irqreturn.h> > #include <linux/iio/iio.h> > #include <linux/iio/trigger.h>
