On Tue, Jun 13, 2023 at 09:46:53AM +0300, Dan Carpenter wrote:
> The qca8k_cled_hw_control_get() function which implements ->hw_control_get
> sets the appropriate bits but does not clear them. This leads to an
> uninitialized variable bug. Fix this by setting mode to zero at the
> start.
>
> Fixes: e0256648c831 ("net: dsa: qca8k: implement hw_control ops")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> v2: In the original patch I fixed qca8k_cled_hw_control_get() instead
> so that patch went to netdev instead of to the led subsystem.
I think his actually needs to be merged via netdev. e0256648c831
("net: dsa: qca8k: implement hw_control ops") is in net-next/main. I
don't see it in leds/master, leds/for-leds-next. Also, git blame shows
mode was added by 0316cc5629d1 ("leds: trigger: netdev: init mode if
hw control already active") which also appears only to be in
net-next/main.
A lot of these LED patches were merged via netdev because they are
cross subsystem.
Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
Andrew
