Hi Christophe,
On Mon, May 29, 2023 at 08:17:18AM +0200, Christophe JAILLET wrote:
> 'fwnode is known to be NULL, at this point, so fwnode_handle_put() is a
> no-op.
>
> Release the reference taken from a previous fwnode_graph_get_port_parent()
> call instead.
>
> Fixes: ca50c197bd96 ("[media] v4l: fwnode: Support generic fwnode for parsing standardised properties")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---
> /!\ THIS PATCH IS SPECULATIVE /!\
> review with care
> ---
> drivers/media/v4l2-core/v4l2-fwnode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-fwnode.c b/drivers/media/v4l2-core/v4l2-fwnode.c
> index 049c2f2001ea..b7dd467c53fd 100644
> --- a/drivers/media/v4l2-core/v4l2-fwnode.c
> +++ b/drivers/media/v4l2-core/v4l2-fwnode.c
> @@ -571,7 +571,7 @@ int v4l2_fwnode_parse_link(struct fwnode_handle *fwnode,
>
> fwnode = fwnode_graph_get_remote_endpoint(fwnode);
> if (!fwnode) {
> - fwnode_handle_put(fwnode);
> + fwnode_handle_put(link->local_node);
link->local_node also needs to be non-NULL for the successful case. The
condition should take that into account. Could you send v2 with that?
> return -ENOLINK;
> }
>
--
Kind regards,
Sakari Ailus
