On Mon, Jun 12, 2023 at 11:00:20AM +0300, Dan Carpenter wrote: > On Mon, Jun 12, 2023 at 07:32:52AM +0000, Oliver Upton wrote: > > > + > > > +out_free_ptimer_irq: > > > + if (info->physical_irq > 0) > > > + free_percpu_irq(host_ptimer_irq, kvm_get_running_vcpus()); > > > > nit: we shouldn't even jump to this label in the first place if > > there was no ptimer irq to set up... Maybe just drop the condition? > > > > The condition is not necessary but I added it deliberately for > readability and in case we ever add more allocations to this function. > I want to keep it. Fair enough. And if your fix is any indicator, we're liable to screw up error handling again in the future :) > > > out_free_irq: > > > > I'd prefer this label be renamed 'out_free_vtimer_irq' to make it > > unambiguous. > > I would prefer this too, but I left it out because I don't like to > rename things unnecessarily. However, since we both prefer this, then > I will rename it. Thanks! Please do send out a v2 when you have a moment, as I'd like to pick this up for 6.5. -- Thanks, Oliver
