> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of > Christophe JAILLET > Sent: Sunday, June 11, 2023 1:44 PM > To: Brandeburg, Jesse <jesse.brandeburg@xxxxxxxxx>; Nguyen, Anthony L > <anthony.l.nguyen@xxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Eric > Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo > Abeni <pabeni@xxxxxxxxxx> > Cc: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>; intel-wired- > lan@xxxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx > Subject: [Intel-wired-lan] [PATCH net-next] ice: Remove managed memory usage > in ice_get_fw_log_cfg() > > There is no need to use managed memory allocation here. The memory is > released at the end of the function. > > You kzalloc()/kfree() to simplify the code. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> > --- Agreed. Reviewed-by: Jacob Keller <jacob.e.keller@xxxxxxxxx> > drivers/net/ethernet/intel/ice/ice_common.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/intel/ice/ice_common.c > b/drivers/net/ethernet/intel/ice/ice_common.c > index eb2dc0983776..4b799a5d378a 100644 > --- a/drivers/net/ethernet/intel/ice/ice_common.c > +++ b/drivers/net/ethernet/intel/ice/ice_common.c > @@ -834,7 +834,7 @@ static int ice_get_fw_log_cfg(struct ice_hw *hw) > u16 size; > > size = sizeof(*config) * ICE_AQC_FW_LOG_ID_MAX; > - config = devm_kzalloc(ice_hw_to_dev(hw), size, GFP_KERNEL); > + config = kzalloc(size, GFP_KERNEL); > if (!config) > return -ENOMEM; > > @@ -857,7 +857,7 @@ static int ice_get_fw_log_cfg(struct ice_hw *hw) > } > } > > - devm_kfree(ice_hw_to_dev(hw), config); > + kfree(config); > > return status; > } > -- > 2.34.1 > > _______________________________________________ > Intel-wired-lan mailing list > Intel-wired-lan@xxxxxxxxxx > https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
