[Also Cc: linux-spdx list and original author mentioned in the license boilerplate] On Tue, Jun 06, 2023 at 01:10:42PM +0200, Franziska Naepelt wrote: > The following checkpatch warnings have been fixed: > - WARNING: Missing or malformed SPDX-License-Identifier tag > - WARNING: Block comments use a trailing */ on a separate line Two different logical changes in a patch - please break them into a 2-patch series, with each patch do one job. And please write the patch description in imperative mood instead (e.g. "Do foo"). > +// SPDX-License-Identifier: GPL-2.0-or-later > /* FCrypt encryption algorithm > * > * Copyright (C) 2006 Red Hat, Inc. All Rights Reserved. NAK! There is also BSD 3-clause boilerplate (from original code that fcrypt.c is based on). Thus, the proper SPDX tag should have been: ``` // SPDX-License-Identifier: GPL-2.0-or-later AND BSD-3-Clause ``` And please also delete the boilerplate. Thanks. -- An old man doll... just what I always wanted! - Clara
Attachment:
signature.asc
Description: PGP signature
