On Tue, May 30, 2023 at 10:49:22AM +0100, Russell King (Oracle) wrote: > On Tue, May 30, 2023 at 12:23:32PM +0300, Dan Carpenter wrote: > > I don't see an issue in r8169_main.c and in drivers/net/phy/phy_device.c > > then I only find the bug from this patch. > > I agree - inspecting the code reveals that "val" would be of type "int". > > > + BUILD_BUG_ON((typeof(val))~0ULL > 0); \ > > I've just thrown this in to my builds, and building for arm64 using > debian stable's gcc, I don't see any errors with genphy_loopback() > suitably hacked, even with r8169 included in the build. Also successfully built with 32-bit ARM gcc. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
